Modify decimal regex to accept positive exponent specifier #5649
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Could we get a test or two for this please |
|
Sure -- will add some test coverage |
|
@tustvold I've added a test asserting correctness of the result of inferring a schema on float data that includes scientific notation data. (with both positive and negative exponents) I modeled it on adjacent tests so I don't think the test itself is likely to be controversial, but this is my first-time committing to this repository so please do let me know if there's anything else you'd like to see on this. |
tustvold
approved these changes
Apr 16, 2024
|
Thank you, looks good to me |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Which issue does this PR close?
Closes #5648
Rationale for this change
If users have float data in scientific format with a positive exponent specifier (e.g "3.106e+04"), the current csv inference mechanism does not work correctly. This change fixes that.
What changes are included in this PR?
Are there any user-facing changes?
This causes a change in schema inference behavior -- it's possible that some user relies on the fact that the current behavior is incorrect. I'm not sure what arrow's policy is around visible changes like this, so if this is change is not allowable I understand.